feat: react-native-screens integration #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade React Navigation deps to latest (7.1.21 & 7.7.0) - Convert Button component from TouchableOpacity to Pressable with touch feedback - Add NavigationSheet component with detents to demonstrate opening RN modal from TrueSheet - Add ModalScreen to show modal presentation from within sheet - Update navigation stack with modal presentation option
…missal - Add conditional support for react-native-screens RNSDismissibleModalProtocol - Implement isDismissible method returning NO to prevent automatic dismissal - Set definesPresentationContext to allow modals to be presented from sheet - Enables React Navigation modals to be presented while TrueSheet remains open
- Check isBeingDismissed before dispatching willDismiss/didDismiss events - Prevents false dismiss events when another modal is presented on top - Preserves sheet state when React components are recreated during navigation - Allows sheets to remain visible behind React Navigation modals
- Navigation from sheets now works without dismissing first - Updated example to show direct navigation - Added tip about optional dismissal for UX preferences
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
patched rn-screens for now. Upstream PR software-mansion/react-native-screens#3415 |
Owner
Author
|
🚀 This pull request is included in v3.0.0-beta.1. See Release 3.0.0-beta.1 for release notes. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
🎉 Features
RNSDismissibleModalProtocolto prevent automatic sheet dismissal when presenting modals🔧 Improvements
release-betascript for streamlined beta release process🛠️ Build & CI
Migration Notes
No breaking changes in this beta release. The react-native-screens integration is fully backward compatible.
What's New in the Example App
NavigationSheetcomponent demonstrating modal presentationDocumentation Updates